Update warning for pyproject.toml license spec#1851
Conversation
6f293a9 to
2248a28
Compare
freakboy3742
left a comment
There was a problem hiding this comment.
Looks good to me; the Win-3.13 failure is a weird one though. I've seen a that pop up recently, but it's always been transient...
2248a28 to
66ce674
Compare
|
The Windows failure definitely isn't transient; it's persisted through multiple re-runs, include full reruns after a rebase. In a desparate search for anything that could be causing this, I noticed that pytest-xdist is installed; I removed it, and the problem went away. I don't know why xdist would be the problem, other than the fact that multi-threading a test suite could cause some interesting cleanup side effects. Tagging @rmartin16 in case you have strong opinions to the contrary; my inclination is to drop xdist for the test suite if it's going to be more stable. |
Would Moreover, though, what if you roll back the recent version bump for pytest-xdist? They reworked how process forking works in the latest version. |
I guess not - so there'd need to be other cleanups.
Well that'd do it... I'll try and see. |
Looks like it doesn't - 3.5.0 generates the same error. So - my inclination is to drop xdist. While parallel support is nice to have, it doesn't yield that much of a performance benefit; plus, dropping the extra dependency is one less cause of error, and one less dependency to keep up to date. Thoughts? |
well, my guess is
I do normally use One more plea perhaps...what if we just don't install |
I can live with that for now. It's also possible that this might be fixed in 3.13-b2, or with a coverage bump at some point; if we get close to 3.13-final and this is still lingering, we can re-evaluate then. |
|
@rmartin16 Looks like the py3.13 exclusion on xdist has worked; If you're happy, feel free to merge. |
Changes
licensefield is specified inpyproject.tomlNotes
PR Checklist: