Skip to content

Defer to install_requirement.py in beeware/.github#1847

Merged
freakboy3742 merged 2 commits intobeeware:mainfrom
rmartin16:remove-install-requirement
May 29, 2024
Merged

Defer to install_requirement.py in beeware/.github#1847
freakboy3742 merged 2 commits intobeeware:mainfrom
rmartin16:remove-install-requirement

Conversation

@rmartin16
Copy link
Member

@rmartin16 rmartin16 commented May 28, 2024

Changes

  • Removes install_requirement.py since it was copied in to beeware/.github for broader use
  • This means it can no longer be used in tox.ini; ideally, this would be useful in tox.ini...but that likely means that the install_requirement.py needs to be incorporated in to a pip-installable package first.....we'll save this for a later day though...

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the remove-install-requirement branch from 3a88f87 to 45216b4 Compare May 28, 2024 23:47
@rmartin16 rmartin16 force-pushed the remove-install-requirement branch from 45216b4 to b43102c Compare May 28, 2024 23:59
@rmartin16
Copy link
Member Author

Once we've got this one merged, I'll rebase #1843 on it and that should wrap up everything for "create package with attestation" PRs.

@rmartin16 rmartin16 marked this pull request as ready for review May 29, 2024 00:46
@rmartin16 rmartin16 requested a review from freakboy3742 May 29, 2024 00:46
@rmartin16
Copy link
Member Author

I just realized that if Tox is going to be building a package for these environment again, I should add in the optimizations for building wheels in tox. One second for another commit...

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@freakboy3742 freakboy3742 merged commit 287bc03 into beeware:main May 29, 2024
@rmartin16 rmartin16 deleted the remove-install-requirement branch May 29, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants