Merged
Conversation
freakboy3742
requested changes
May 22, 2024
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
The code change looks good; it's now failing because we still have PPB checks in the CI configuration.
AstraLuma
added a commit
to AstraLuma/briefcase-template
that referenced
this pull request
May 22, 2024
This was referenced May 22, 2024
freakboy3742
approved these changes
May 22, 2024
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for show of support in Briefcase that you're willing to take the leap on externally hosting the plugin!
4 tasks
This was referenced May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per current Briefcase best practices, migrating the PPB integration to PPB itself.
Companion: ppb/pursuedpybear#722
PR Checklist: