Fix macOS camera / microphone / photo library permissions#1820
Merged
freakboy3742 merged 7 commits intobeeware:mainfrom May 21, 2024
Merged
Fix macOS camera / microphone / photo library permissions#1820freakboy3742 merged 7 commits intobeeware:mainfrom
freakboy3742 merged 7 commits intobeeware:mainfrom
Conversation
freakboy3742
approved these changes
May 21, 2024
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
I've got a minor tweak to the release note; but otherwise, this looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Built macOS app crashed when camera access was requested, due to the fact that (whilst the
Entitlements.plistwas being updated properly) the expected info was not being added toInfo.plistThis PR fixes this issue by ensuring that, when the user provides
permissions.camera,permissions.microphone, orpermissions.photo_library, the messages are added toInfo.plistunder the relevant property key.Changes
test_create.pyfor macOSmacOSCreateMixinin__init__.pyfor macOSPR Checklist: