Merged
Conversation
freakboy3742
approved these changes
Mar 7, 2024
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
The towncrier update makes me mildly nervous, because we only ever run towncrier when we're doing a release, so there's no real exercising of this until we actually cut a release. I'm not sure there's a better option, though - testing release notes is going to be near impossible, and tweaking a towncrier config for compatibility as part of a release isn't the end of the world.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Notes
towncrier, I confirmed the changes todocs/background/releases.rstwere the same for this version as the previous.towncrierintoxseemingly requires that Briefcase has been installed...otherwise, the version is indeterminable.PR Checklist: