ADB log tailing color output#1676
Conversation
|
In all its glory in CI: https://github.com/beeware/briefcase/actions/runs/8181483777/job/22371536462?pr=1676#step:28:596 One thing I was considering is that there isn't any way to disable this... |
|
I went ahead and added support to detect broader color usage so I wanted the tests to actually confirm the assumptions I'm making about Rich...but Rich is evaluating many aspects of the environment to determine if colors should be enabled. Trying to mock all of them to deal with the permutations of environments in which tests can run start to really question if we're testing those assumptions....or just my ability to mock the hell out of Rich. So, I'll have to dumb down the tests to just verify the outcomes of those assumptions are implemented correctly. |
- Update adb log tailing to only use color output if Briefcase is already using it
freakboy3742
left a comment
There was a problem hiding this comment.
It's definitely colourful... :-)
Not much to fault here. I guess we'll learn pretty soon if ANSI sequences appear anywhere in ADB logs other than the start of the line; but we can fix that pretty quickly if we need to.
I'm also not overly concerned about testing how Rich interprets things - at some point, you have to be comfortable that the tools you're using are testing their own behavior, and I think Rich falls in that camp.
Changes
Notes
PR Checklist: