Skip to content

Support testing against Python 3.13#1495

Merged
freakboy3742 merged 1 commit intobeeware:mainfrom
rmartin16:ci-python-3.13
Feb 17, 2024
Merged

Support testing against Python 3.13#1495
freakboy3742 merged 1 commit intobeeware:mainfrom
rmartin16:ci-python-3.13

Conversation

@rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Oct 16, 2023

Changes

  • Add support for CI to test Python 3.13
  • Add support for tox to run using Python 3.13

Issues

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content of the PR looks good; although it's missing the setup.cfg metadata declaring Py3.13 compatibility.

On top of that, I think we should hold off merging until coverage and CI is passing. We have a higher threshold for failures on dev releases, but as we're still early in the 3.13 cycle, I think we can afford to hold off until there's basic support in place.

@rmartin16
Copy link
Member Author

Agreed; I was mostly just curious where support stands. At a minimum, we're waiting on a release of coverage.

@rmartin16
Copy link
Member Author

Pytest 8.0.1 released with the needed fix. I also added the classifier for Python 3.13.

@rmartin16 rmartin16 marked this pull request as ready for review February 16, 2024 22:40
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fairly straightforward; Approved on the basis that it does what it says on the tin.

As a follow up to this - we should probably turn on macOS ARM64 testing as well. That will start to explode the size of the CI matrix to absurd levels - but we can probably cut back on doing every python version on every OS, and limit ourselves to "min and max versions" (or min, max and dev) on every OS, and every version on one OS (probably linux, given there are more available runners).

@freakboy3742 freakboy3742 merged commit 2e81d10 into beeware:main Feb 17, 2024
@rmartin16 rmartin16 deleted the ci-python-3.13 branch February 17, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants