Support testing against Python 3.13#1495
Conversation
ee7cb21 to
78bbe8d
Compare
freakboy3742
left a comment
There was a problem hiding this comment.
Content of the PR looks good; although it's missing the setup.cfg metadata declaring Py3.13 compatibility.
On top of that, I think we should hold off merging until coverage and CI is passing. We have a higher threshold for failures on dev releases, but as we're still early in the 3.13 cycle, I think we can afford to hold off until there's basic support in place.
78bbe8d to
fbaf2b7
Compare
|
Agreed; I was mostly just curious where support stands. At a minimum, we're waiting on a release of |
fbaf2b7 to
6e90bc0
Compare
6e90bc0 to
22bc0a0
Compare
22bc0a0 to
3cc406b
Compare
|
Pytest 8.0.1 released with the needed fix. I also added the classifier for Python 3.13. |
freakboy3742
left a comment
There was a problem hiding this comment.
Looks fairly straightforward; Approved on the basis that it does what it says on the tin.
As a follow up to this - we should probably turn on macOS ARM64 testing as well. That will start to explode the size of the CI matrix to absurd levels - but we can probably cut back on doing every python version on every OS, and limit ourselves to "min and max versions" (or min, max and dev) on every OS, and every version on one OS (probably linux, given there are more available runners).
Changes
toxto run using Python 3.13Issues
coverageneeds support for Python 3.13 (added with v7.4.1)pytestrelease that includes Using Python 3.13.0a3+ on Windows whenUSERNAMEenv var is masked/unset,get_user()leaksOSErrorand breaks (at least)tmp_pathusage pytest-dev/pytest#11874PR Checklist: