Removed all usage of six and dropped support for Python 2. #2374
+55
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexandre Detiste <[email protected]> Co-authored-by: Christian Clauss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
main)Fixes Issue:
Removes six and drops support for Python 2.
This is pretty much same MR from #2338 but with simple pipeline fixes and
python.mustachechanges. Hence, added @a-detiste and @cclauss as co-authors.Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)
@bitwiseman Please review when you can. Not sure how to test. I hope the pipelines can take care of that.