Prevent Telnet peer disconnects from triggering the TCP watchdog - #1742
Open
figamore wants to merge 1 commit into
Open
Prevent Telnet peer disconnects from triggering the TCP watchdog#1742figamore wants to merge 1 commit into
figamore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A stalled or dead Telnet peer could block
TelnetClient::write()indefinitely,starving the FreeRTOS TCP task watchdog and causing an unintended reboot.
Changes
WiFiClient::write()with::send(..., MSG_DONTWAIT)so writes never hold the CPU.\r\nnormalization correct across fragmented
write()calls.TX_IDLE_WAIT_MS(50 ms) when themachine is idle, but drops immediately during motion to keep jogging/running unaffected.
TX_STALL_LIMIT(10) consecutive lines are disconnected and reaped on the nextpoll(), freeing the slot for a healthy reconnect.