for expander pin initializations, allow up to 75 milliseconds for a response - #1625
Open
ajmirsky wants to merge 1 commit into
Open
for expander pin initializations, allow up to 75 milliseconds for a response#1625ajmirsky wants to merge 1 commit into
ajmirsky wants to merge 1 commit into
Conversation
MitchBradley
reviewed
Jan 1, 2026
| _ackwait = 1; | ||
| for (size_t i = 0; i < 20; i++) { | ||
| for (size_t i = 0; i < 75000; i++) { // allow uart channel 75 milliseconds to respond | ||
| pollLine(nullptr); |
Collaborator
There was a problem hiding this comment.
75000 x 10 us is 750 ms, not 75. Which do you mean?
| return _ackwait == 0; | ||
| } | ||
| delay_us(100); | ||
| delay_us(10); |
Collaborator
There was a problem hiding this comment.
Is polling at 10 us intervals actually helpful?
Collaborator
|
Still waiting for answers to the review questions. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the limitations of some UI devices for auto-reporting, certain microcontrollers need a longer time to respond to
EXPmessages.