custom esp32 WebServer library which allows for conditional compilation of Auth code - #1216
Open
craiglink wants to merge 1 commit into
Open
custom esp32 WebServer library which allows for conditional compilation of Auth code#1216craiglink wants to merge 1 commit into
craiglink wants to merge 1 commit into
Conversation
…out Authentication code to match our ENABLE_AUTHENTICATION preprocessor definition usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
leverage custom esp32 WebServer library which conditionally compiles out Authentication code to match our ENABLE_AUTHENTICATION preprocessor definition usage.
craiglink/arduino-esp32-libraries-WebServer@release/v2.x...no-auth
Additionally, it fixes a const array to be static const and reduce RAM usage by 320 bytes.
PR for the static const has been submitted back to espressif : espressif/arduino-esp32#9594
[env:wifi]
RAM: [=== ] 27.1% (used 88944 bytes from 327680 bytes)
Flash: [========= ] 90.8% (used 1785069 bytes from 1966080 bytes)