Skip to content

Conversation

@mtgto
Copy link
Collaborator

@mtgto mtgto commented Mar 5, 2021

node-sqlite3 v5.0.0+ adopt N-API instead of NAN
https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#500
TryGhost/node-sqlite3#830

I understand a bit about N-API, but I know it reduces time to compile sqlite3:

Technically, with the new N-API support we should already be able to support electron 9.0.0 without adding it to our build matrix. (Same goes for any future Electron release, even 8.3 & 7.3, etc..)

TryGhost/node-sqlite3#1335 (comment)

@mtgto mtgto requested a review from hokaccha March 5, 2021 12:11
.yarnrc Outdated
@@ -1,5 +1,4 @@
save-exact true
disturl "https://electronjs.org/headers"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L2-L5は消してもよさそう・・・?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlite のビルドのために入れた設定だった気がするけど何も覚えてないので動くなら yarnrc ごと消してよさそう

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1行目は別の設定ぽいですね。(1行目も個人的には不要だとは思いますが)。

@mtgto mtgto merged commit a741618 into bdash-app:master Mar 6, 2021
@mtgto mtgto deleted the update-sqlite3-502 branch March 6, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants