Skip to content

Comments

DEVSU-2761 Update logo images for printed reports#474

Closed
bnguyen-bcgsc wants to merge 2 commits intodevelopfrom
feature/DEVSU-2761-update-print-report-header-logo
Closed

DEVSU-2761 Update logo images for printed reports#474
bnguyen-bcgsc wants to merge 2 commits intodevelopfrom
feature/DEVSU-2761-update-print-report-header-logo

Conversation

@bnguyen-bcgsc
Copy link
Contributor

  • DEVSU-2761
  • Update logo images in images table with new GSC logo
  • Remove unintentional image

- Update logo images in images table with new GSC logo
- Remove unintentional image
@bnguyen-bcgsc bnguyen-bcgsc self-assigned this Jan 14, 2026
@bnguyen-bcgsc bnguyen-bcgsc added the enhancement New feature or request label Jan 14, 2026
@github-actions
Copy link

Unit Test Results

    1 files  ±0    63 suites  ±0   4m 9s ⏱️ +14s
643 tests ±0  642 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
640 runs  ±0  639 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 5d79f01. ± Comparison against base commit 0a1fdae.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.34%. Comparing base (0a1fdae) to head (5d79f01).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #474   +/-   ##
========================================
  Coverage    77.34%   77.34%           
========================================
  Files          185      185           
  Lines         6684     6684           
  Branches       832      832           
========================================
  Hits          5170     5170           
  Misses        1426     1426           
  Partials        88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@elewis2
Copy link
Collaborator

elewis2 commented Jan 19, 2026

Any way we can store this image in the repo as a viewable image file and convert it to the string for upload in the migration?

@elewis2
Copy link
Collaborator

elewis2 commented Jan 26, 2026

As noted on rc - I don't think we want this in code, will find a way to load the image via the client

Copy link
Collaborator

@elewis2 elewis2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to have this in the code base

@elewis2
Copy link
Collaborator

elewis2 commented Feb 6, 2026

closing as this change was done via the client

@elewis2 elewis2 closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants