[WIP] Fix external relative path dependencies outside cargo workspace #3809
+962
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d#3089) This test reproduces the bug where crate_universe fails when a Cargo workspace member has a path dependency pointing outside the Cargo workspace root (but still inside the Bazel workspace). The test is expected to fail until the bug is fixed.
When a Cargo workspace member has a path dependency pointing outside the Cargo workspace root (but still inside the Bazel workspace), crate_universe now correctly symlinks the external crate to the appropriate location in the temporary splicing directory. The fix: 1. Added symlink_external_path_deps() function in splicer.rs that extracts path dependencies from manifests and symlinks external ones 2. Call this function from splice_workspace and splice_package 3. Also call it from cargo_tree_resolver's copy_project_with_explicit_deps_on_all_transitive_proc_macros to handle the tree resolver's temp directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3089.
AI-generated, I still need to understand this better and test it more before putting it up for review.