This repository was archived by the owner on Feb 6, 2024. It is now read-only.
Support resolving YAML streams in Go resolver#444
Merged
rbe-toolchains-pr-bot merged 1 commit intobazelbuild:masterfrom Oct 17, 2019
Merged
Support resolving YAML streams in Go resolver#444rbe-toolchains-pr-bot merged 1 commit intobazelbuild:masterfrom
rbe-toolchains-pr-bot merged 1 commit intobazelbuild:masterfrom
Conversation
smukherj1
requested review from
alex1545,
chrislovecnm,
erain and
nlopezgi
as code owners
Contributor
Author
|
Relevant for #433 |
nlopezgi
approved these changes
Oct 17, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alex1545
reviewed
Oct 17, 2019
Comment on lines
+56
to
+64
| testCases := []struct { | ||
| name string | ||
| // yamlDocs is a string with one or more YAML documents. | ||
| yamlDocs string | ||
| // want is the list of strings the YAML walker should visit. | ||
| want []string | ||
| // wantDocs is the number of docs the resolver should have operated on. | ||
| wantDocs int | ||
| }{ |
Contributor
There was a problem hiding this comment.
Not sure if it's a valid scenario, but can we have an empty yaml file? If so, can we have a test for that too?
- val1
- val2
---
---
- val3
- val4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #443