This repository was archived by the owner on Feb 6, 2024. It is now read-only.
Return providers instead of struct from rule impl functions#300
Merged
alex1545 merged 5 commits intobazelbuild:masterfrom Apr 1, 2019
Merged
Conversation
alex1545
requested review from
chrislovecnm,
erain,
nlopezgi,
smukherj1 and
xingao267
as code owners
xingao267
reviewed
Apr 1, 2019
xingao267
reviewed
Apr 1, 2019
xingao267
approved these changes
Apr 1, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alex1545, xingao267 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the incompatible change via the
--incompatible_disallow_struct_provider_syntaxflag described here.