[email protected] add support for std::format

[mutalibmohammed]

This PR adds support to use std::format available in C++20 onwards with spdlog.

Added a use_fmt flag to allow users to use std::format instead of fmt.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[bazel-io]

Hello @Vertexwahn, @c8ef, modules you maintain (spdlog) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

[gemini-code-assist]

Code Review

This pull request adds a new version 1.16.0.bcr.2 for spdlog to introduce support for std::format via a use_fmt build flag. The changes look good and correctly implement the feature toggle using select() in the BUILD.bazel file and test both configurations in presubmit.yml. I've found a couple of minor issues in the presubmit.yml file related to formatting and consistency that could affect presubmit jobs. Please see my comments for details.

[mutalibmohammed]

@bazel-io skip_check unstable_url

[bazel-io]

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

Require module maintainers' approval for newly pushed changes.

Require module maintainers' approval for newly pushed changes.

[mutalibmohammed]

Hi @meteorcloudy @bazelbuild/bcr-maintainers, could you have a look at why the CI is failing for the intel macos machine?

[Vertexwahn]

@mutalibmohammed I think that was just a temporary error (Error in download: java.io.IOException: Error downloading [file:/Users/buildkite/builds/bk-macos-intel-hsll/bazel/bcr-presubmit/modules/spdlog/1.16.0.bcr.2/MODULE.bazel] to /private/var/tmp/_bazel_buildkite/9d3aed0c624f300002dc845796c6aa9b/external/spdlog+/MODULE.bazel: /private/var/tmp/_bazel_buildkite/9d3aed0c624f300002dc845796c6aa9b/external/spdlog+/MODULE.bazel (Permission denied)

Please reabase your PR and push again - lets see if this happens again