Add paho.mqtt.cpp version 1.3.2 #6650
Open
+136
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hello @lalten, modules you maintain (paho.mqtt.cpp) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds version 1.3.2 of paho.mqtt.cpp. The overall structure is good and follows the Bazel Central Registry guidelines, including the addition of a test module. However, there is a critical issue with the provided patch file (change_test_urls.patch) which appears to be malformed due to inconsistent file paths. This will likely prevent the patch from being applied correctly, failing the build. Please see the detailed comment on the patch file.
johnor
force-pushed
the
pahomqttcpp132
branch
from
118ca83 to
cd9633b
Compare
johnor
force-pushed
the
pahomqttcpp132
branch
from
cd9633b to
660319b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based the build rules on the existing ones for 1.5.2. Hade to change the test urls though since mqtt.eclipseprojects.io is no longer maintained (eclipse-mosquitto/mosquitto#3303)