Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions modules/numactl/2.0.19.bcr.1/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
"""https://github.com/numactl/numactl"""

module(
name = "numactl",
version = "2.0.19.bcr.1",
bazel_compatibility = [">=7.2.1"],
)

bazel_dep(name = "rules_cc", version = "0.2.4")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
1 change: 1 addition & 0 deletions modules/numactl/2.0.19.bcr.1/overlay/.bazelignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
test
232 changes: 232 additions & 0 deletions modules/numactl/2.0.19.bcr.1/overlay/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,232 @@
load("@bazel_skylib//rules:write_file.bzl", "write_file")
load("@rules_cc//cc:cc_binary.bzl", "cc_binary")
load("@rules_cc//cc:cc_library.bzl", "cc_library")

LINUX_ONLY = select({
"@platforms//os:linux": [],
"//conditions:default": ["@platforms//:incompatible"],
})

# Generate config.h
write_file(
name = "gen_config_h",
out = "config.h",
content = [
"/* config.h - Generated by Bazel */",
"",
"/* Define to 1 if you have standard C headers */",
"#define STDC_HEADERS 1",
"#define HAVE_STDIO_H 1",
"#define HAVE_STDLIB_H 1",
"#define HAVE_STRING_H 1",
"#define HAVE_STRINGS_H 1",
"#define HAVE_INTTYPES_H 1",
"#define HAVE_STDINT_H 1",
"#define HAVE_UNISTD_H 1",
"#define HAVE_SYS_TYPES_H 1",
"#define HAVE_SYS_STAT_H 1",
"",
"/* TLS support */",
"#if defined(__GNUC__) || defined(__clang__)",
"#define TLS __thread",
"#endif",
"",
"/* Symver attribute support - disabled for Bazel builds */",
"/* #undef HAVE_ATTRIBUTE_SYMVER */",
"",
"/* Package information */",
"#define PACKAGE \"numactl\"",
"#define PACKAGE_NAME \"numactl\"",
"#define PACKAGE_VERSION \"2.0.19\"",
"#define PACKAGE_STRING \"numactl 2.0.19\"",
"#define VERSION \"2.0.19\"",
"",
],
newline = "unix",
)

# Common compiler flags
COMMON_COPTS = ["-w"]

# Common headers for internal use
INTERNAL_HDRS = [
"numaint.h",
"util.h",
"affinity.h",
"sysfs.h",
"rtnetlink.h",
"shm.h",
"clearcache.h",
"mt.h",
"stream_lib.h",
]

# libnuma: NUMA policy library
cc_library(
name = "numa",
srcs = [
"affinity.c",
"distance.c",
"libnuma.c",
"rtnetlink.c",
"syscall.c",
"sysfs.c",
":gen_config_h",
] + INTERNAL_HDRS,
hdrs = [
"numa.h",
"numacompat1.h",
"numaif.h",
],
additional_linker_inputs = ["versions.ldscript"],
copts = COMMON_COPTS,
includes = ["."],
linkopts = [
"-Wl,--version-script=$(location versions.ldscript)",
"-Wl,-init,numa_init",
"-Wl,-fini,numa_fini",
],
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
alwayslink = True,
)

# Utility library for command-line tools and tests
cc_library(
name = "util",
srcs = [
"util.c",
":gen_config_h",
],
hdrs = ["util.h"],
copts = COMMON_COPTS,
includes = ["."],
linkstatic = True,
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
deps = [":numa"],
alwayslink = True,
)
Comment on lines +95 to +109
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The util library is defined with linkstatic = True and alwayslink = True. These attributes are quite restrictive for consumers of this library. linkstatic = True forces static linking on all dependents, and alwayslink = True forces the library to be linked even if no symbols are used from it. Since this library has public visibility, these settings can be problematic for downstream users. It's better to let consumers decide how to link. The binaries within this module already request static linking via their own linkstatic attribute, so these attributes on the library are not necessary for them.

To provide more flexibility, I suggest removing linkstatic = True and alwayslink = True.

cc_library(
    name = "util",
    srcs = [
        "util.c",
        ":gen_config_h",
    ],
    hdrs = ["util.h"],
    copts = COMMON_COPTS,
    includes = ["."],
    target_compatible_with = LINUX_ONLY,
    visibility = ["//visibility:public"],
    deps = [":numa"],
)


# numactl: NUMA policy control
cc_binary(
name = "numactl",
srcs = [
"numactl.c",
"shm.c",
"shm.h",
":gen_config_h",
],
copts = COMMON_COPTS + ["-DVERSION=\\\"2.0.19\\\""],
linkstatic = True,
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
deps = [
":numa",
":util",
],
)

# numastat: NUMA statistics
cc_binary(
name = "numastat",
srcs = [
"numastat.c",
":gen_config_h",
],
copts = COMMON_COPTS + [
"-std=gnu99",
"-DVERSION=\\\"2.0.19\\\"",
],
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
)

# numademo: NUMA demonstration/benchmark
cc_binary(
name = "numademo",
srcs = [
"clearcache.c",
"clearcache.h",
"mt.c",
"mt.h",
"numademo.c",
"stream_lib.c",
"stream_lib.h",
":gen_config_h",
],
copts = COMMON_COPTS + [
"-O3",
"-ffast-math",
"-funroll-loops",
"-DHAVE_STREAM_LIB",
"-DHAVE_MT",
"-DHAVE_CLEAR_CACHE",
],
linkopts = ["-lm"],
linkstatic = True,
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
deps = [
":numa",
":util",
],
)

# migratepages: Migrate pages of a process
cc_binary(
name = "migratepages",
srcs = [
"migratepages.c",
":gen_config_h",
],
copts = COMMON_COPTS,
linkstatic = True,
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
deps = [
":numa",
":util",
],
)

# migspeed: Measure migration speed
cc_binary(
name = "migspeed",
srcs = [
"migspeed.c",
":gen_config_h",
],
copts = COMMON_COPTS,
linkstatic = True,
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
deps = [
":numa",
":util",
],
)

# memhog: Memory allocation test
cc_binary(
name = "memhog",
srcs = [
"memhog.c",
":gen_config_h",
],
copts = COMMON_COPTS,
linkstatic = True,
target_compatible_with = LINUX_ONLY,
visibility = ["//visibility:public"],
deps = [
":numa",
":util",
],
)

# Convenience alias
alias(
name = "libnuma",
actual = ":numa",
visibility = ["//visibility:public"],
)
Comment on lines +228 to +232
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

According to the BCR style guide, for C++ overlays, there should be a public target named after the module.1 The module name is numactl, but there is no library target with this name. Please add an alias from numactl to the main library target :numa for better usability and to conform to the style guide.

alias(
    name = "libnuma",
    actual = ":numa",
    visibility = ["//visibility:public"],
)

alias(
    name = "numactl",
    actual = ":numa",
    visibility = ["//visibility:public"],
)

Style Guide References

Footnotes

  1. For C++ overlays: ensure a public target named after the module (or alias libfoo -> foo); visibility is minimal but includes //visibility:public for intended APIs.

11 changes: 11 additions & 0 deletions modules/numactl/2.0.19.bcr.1/overlay/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
"""https://github.com/numactl/numactl"""

module(
name = "numactl",
version = "2.0.19",
bazel_compatibility = [">=7.2.1"],
)

bazel_dep(name = "rules_cc", version = "0.2.4")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
100 changes: 100 additions & 0 deletions modules/numactl/2.0.19.bcr.1/overlay/test/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
load("@rules_cc//cc:cc_test.bzl", "cc_test")

# Common configuration for all tests
COMMON_COPTS = ["-Wall"]

# Linux-only constraint - all numactl tests require Linux
LINUX_ONLY = select({
"@platforms//os:linux": [],
"//conditions:default": ["@platforms//:incompatible"],
})

# Test programs from Makefile.am
# All tests are Linux-specific
# Tests that work without NUMA hardware
TEST_CASES = {
"ftok": ["ftok.c"],
"mynode": ["mynode.c"],
"pagesize": ["pagesize.c"],
}

# Tests that require NUMA hardware/kernel support (tagged as manual)
MANUAL_TEST_CASES = {
"distance": ["distance.c"],
"mbind_mig_pages": ["mbind_mig_pages.c"],
"migrate_pages": ["migrate_pages.c"],
"move_pages": ["move_pages.c"],
"nodemap": ["nodemap.c"],
"realloc_test": ["realloc_test.c"],
"tshared": ["tshared.c"],
}

# Generate basic tests
[cc_test(
name = name,
srcs = srcs,
copts = COMMON_COPTS,
linkstatic = True,
target_compatible_with = LINUX_ONLY,
deps = ["@numactl//:numa"],
) for name, srcs in TEST_CASES.items()]

# Generate manual tests (require NUMA hardware)
[cc_test(
name = name,
srcs = srcs,
copts = COMMON_COPTS,
linkstatic = True,
tags = ["manual"],
target_compatible_with = LINUX_ONLY,
deps = ["@numactl//:numa"],
) for name, srcs in MANUAL_TEST_CASES.items()]

# Tests that also need util library
cc_test(
name = "node-parse",
srcs = ["node-parse.c"],
copts = COMMON_COPTS,
linkstatic = True,
target_compatible_with = LINUX_ONLY,
deps = [
"@numactl//:numa",
"@numactl//:util",
],
)

cc_test(
name = "prefered",
srcs = ["prefered.c"],
copts = COMMON_COPTS,
linkstatic = True,
tags = ["manual"], # Requires NUMA hardware
target_compatible_with = LINUX_ONLY,
deps = [
"@numactl//:numa",
"@numactl//:util",
],
)

cc_test(
name = "tbitmap",
srcs = ["tbitmap.c"],
copts = COMMON_COPTS,
linkstatic = True,
target_compatible_with = LINUX_ONLY,
deps = [
"@numactl//:numa",
"@numactl//:util",
],
)

# Test that is known to be broken (per Makefile.am comment)
cc_test(
name = "randmap",
srcs = ["randmap.c"],
copts = COMMON_COPTS,
linkstatic = True,
tags = ["manual"],
target_compatible_with = LINUX_ONLY,
deps = ["@numactl//:numa"],
)
14 changes: 14 additions & 0 deletions modules/numactl/2.0.19.bcr.1/overlay/test/MODULE.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
module(
name = "numactl_test",
version = "0.0.0",
)

bazel_dep(name = "numactl", version = "0.0.0")
local_path_override(
module_name = "numactl",
path = "../",
)

bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "rules_cc", version = "0.2.4")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
14 changes: 14 additions & 0 deletions modules/numactl/2.0.19.bcr.1/presubmit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
bcr_test_module:
module_path: "test"
matrix:
platform: ["rockylinux8", "ubuntu2004", "ubuntu2004_arm64"]
bazel: ["7.x", "8.x", "rolling"]
tasks:
verify_targets:
name: "Run test module"
platform: ${{ platform }}
bazel: ${{ bazel }}
build_targets:
- "@numactl//..."
test_targets:
- "//..."
Loading
Loading