Add 'pending' commands (except the git ones) to toybox. #6597
Conversation
In particular, this includes the 'sh' command, which is very helpful in a lot of situations. The git commands are excluded because they rely on OpenSSL's SHA implementation and would pull that in as a dependency, increasing the module's footprint significantly.
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (toybox) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new version 0.8.12.bcr.1 for the toybox module, enabling pending commands like sh, which is a valuable addition. The changes are well-structured and mostly adhere to the Bazel Central Registry policies. I have one suggestion to improve the correctness and maintainability of the BUILD file by properly categorizing source and header files.
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
bazel-io
dismissed
mering’s stale review
Require module maintainers' approval for newly pushed changes.
symlinks aren't allowed, and the github user ID is a number, not a string...
bazel-io
dismissed
mering’s stale review
Require module maintainers' approval for newly pushed changes.
meteorcloudy
added
the
presubmit-auto-run
Co-authored-by: Marcel <[email protected]>
4 participants
In particular, this includes the 'sh' command, which is very helpful in a lot of situations.
The git commands are excluded because they rely on OpenSSL's SHA implementation and would pull that in as a dependency, increasing the module's footprint significantly.
The toybox repo doesn't use stable release URLs, unfortunately.
@bazel-io skip_check unstable_url