Skip to content

[email protected] #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[email protected] #6550

wants to merge 1 commit into from
+110 −1

Conversation

@aspect-marvin
Copy link
Contributor

@aspect-marvin aspect-marvin commented Nov 15, 2025

@bazel-io
Copy link
Member

bazel-io commented Nov 15, 2025

Hello @alexeagle, @gregmagolan, @jbedard, @thesayyn, modules you maintain (aspect_rules_ts) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 3.8.0 of the aspect_rules_ts module. The changes appear to be correct and adhere to the Bazel Central Registry's guidelines. All required files for the new version, including MODULE.bazel, source.json, and presubmit.yml, are present and correctly structured. The update to metadata.json is also correct. I found no issues of high or critical severity.

jbedard
jbedard previously approved these changes Nov 15, 2025
View reviewed changes
bazel-io
bazel-io previously approved these changes Nov 15, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@meteorcloudy meteorcloudy force-pushed the aspect_rules_ts-v3.8.0 branch from 392ca25 to b5b522e Compare November 18, 2025 09:14
@bazel-io bazel-io dismissed stale reviews from jbedard and themself November 18, 2025 09:14

Require module maintainers' approval for newly pushed changes.

@meteorcloudy meteorcloudy force-pushed the aspect_rules_ts-v3.8.0 branch from b5b522e to 23df91f Compare November 18, 2025 09:17
@jbedard
Copy link
Contributor

jbedard commented Nov 18, 2025

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Nov 18, 2025
bazel-io
bazel-io approved these changes Nov 18, 2025
View reviewed changes
Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@bazel-io bazel-io bazel-io approved these changes

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@jbedard jbedard jbedard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aspect-marvin @bazel-io @jbedard @meteorcloudy @alexeagle