Make sure that only expands existing response files #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
approved these changes
Oct 29, 2024
auto-merge was automatically disabled
October 30, 2024 21:07
Head branch was pushed to by a user without write access
Contributor
Author
|
@fmeum - Thank you for the approval. Had the formatting issue auto fixed. Please take another look. |
fmeum
reviewed
Oct 30, 2024
fmeum
approved these changes
Oct 31, 2024
fmeum
pushed a commit
that referenced
this pull request
Oct 31, 2024
I'm @ormandi's colleague and was following #409. It seems the formatter wanting to remove quotes is due to Trunk by default using the `-s` flag for `shfmt` to simplify code. Either there is a bug in `shfmt` that makes it overly aggressive in removing quotes or what it's doing is actually correct, but I'm not enough of a shell expert to tell. This PR sidesteps the issue by customizes the Trunk config to avoid passing `-s`.
Otherwise the parameter is more than likely a prefix of an `@rpath` so it is probably better off leaving as it is.
…ments can contain spaces.
fmeum
force-pushed
the
issue-408-porting-relpath-fix
branch
from
2f2bea3 to
7dbe9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the parameter is more than likely a prefix of an
@rpathso it is probably better off leaving as it is.This simply ports the following fix: bazelbuild/bazel#13148
Resolves #408