Skip to content

fix: use forward slash separator in Maven purl format #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shs96c merged 1 commit into from
Jan 22, 2026
+2 −2
Merged

fix: use forward slash separator in Maven purl format #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion private/lib/coordinates.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def to_purl(coords, repository):
to_return = "pkg:maven/"

unpacked = unpack_coordinates(coords)
to_return += "{group}:{artifact}@{version}".format(
to_return += "{group}/{artifact}@{version}".format(
artifact = unpacked.artifact,
group = unpacked.group,
version = unpacked.version,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/jvm_import/jvm_import_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def _does_jvm_import_export_a_package_provider_impl(ctx):

asserts.true(env, PackageInfo in ctx.attr.src)
package_info = ctx.attr.src[PackageInfo]
asserts.equals(env, "pkg:maven/com.google.code.findbugs:[email protected]", package_info.purl)
asserts.equals(env, "pkg:maven/com.google.code.findbugs/[email protected]", package_info.purl)

# The metadata is applied directly to the target in this case, so there should
# not be any transitive metadata. Apparently.
Expand Down