Fix issue where MavenPublisher hangs indefinitely#1444
Merged
shs96c merged 3 commits intoOct 6, 2025
Merged
Conversation
Co-authored-by: Farid Zakaria <[email protected]>
vinnybod
commented
Sep 2, 2025
vinnybod
commented
Sep 2, 2025
vinnybod
commented
Sep 2, 2025
| signingMetadata, | ||
| executor)); | ||
|
|
||
| if (!Strings.isNullOrEmpty(extraArtifacts)) { |
Contributor
Author
There was a problem hiding this comment.
empty string being passed for extraArtifacts was causing an IndexOutOfBounds exception
vinnybod
commented
Sep 2, 2025
fzakaria
reviewed
Sep 2, 2025
Comment on lines
+102
to
103
| } else if (termAvailable && consoleAvailable || System.getenv("FORCE_ANSI") != null) { | ||
| return new AnsiConsoleListener(); |
Contributor
There was a problem hiding this comment.
I wanted to test the AnsiConsoleListener in a test to validate the cleanup; unfortunately Bazel test runner calls System.exit making it difficult to test it. [slack]
shs96c
reviewed
Sep 10, 2025
| credentials, | ||
| in_memory_pgp_sign( | ||
| item, signingMetadata.signingKey, signingMetadata.signingPassword))); | ||
| in_memory_pgp_sign(item, signingMetadata.signingKey, signingMetadata.signingPassword), |
Collaborator
There was a problem hiding this comment.
Note to self: refactor this method name.
vinnybod
commented
Sep 12, 2025
shs96c
approved these changes
Oct 6, 2025
Collaborator
shs96c
left a comment
shs96c
left a comment
There was a problem hiding this comment.
Approving and merging. Will do a follow up PR to address nits, but that won't block this.
| ) | ||
|
|
||
| java_library( | ||
| name = "MavenPublisherLib", |
Collaborator
There was a problem hiding this comment.
Only binaries get CamelCased names. maven would be a find name for this target
simonresch
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Dec 22, 2025
bazel-contrib/rules_jvm_external#1444 changed the command line usage of the MavenPublisher class which now requires a forth boolean argument to configure `publishMavenMetadata`.
simonresch
added a commit
to CodeIntelligenceTesting/jazzer
that referenced
this pull request
Dec 22, 2025
bazel-contrib/rules_jvm_external#1444 changed the command line usage of the MavenPublisher class which now requires a forth boolean argument to configure `publishMavenMetadata`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pull request #1260 introduced an issue where publishing could hang indefinitely because it integrated the existing
HttpDownloaderintoMavenPublisher.HttpDownloadercontained anEventListenerthat was not being closed.This updates the
HttpDownloaderto be auto-closeable and it closes the listener on close.MavenPublishernow uses it with a try-with-resources block.There are now some end to end tests for MavenPublisher that tests local and http publishing. To make testing easier, we refactored the
MavenPublisherentrypoint so that there is arunfunction that doesn't need to read from environment variables.