Remove hardcoded javadocopts#1212
Merged
shs96c merged 8 commits intoSep 7, 2024
Merged
Conversation
vinnybod
requested review from
Wyverald,
cheister,
jin and
shs96c
as code owners
Collaborator
|
I think this is reasonable for folks to override the default instead of the rule always adding hardcoded defaults. @shs96c wdyt? |
shs96c
reviewed
Aug 27, 2024
Collaborator
shs96c
left a comment
shs96c
left a comment
There was a problem hiding this comment.
Thank you for your patience with this review.
One small change requested, but LGTM. Could you also please run ./scripts/generate_docs.sh since you're updating the stardoc too.
Contributor
Author
|
After making the suggested changes and merging master, some tests are failing. will have to look into it later |
Collaborator
|
@vinnybod, please tag me when you'd like me to have another look at this. |
Contributor
Author
|
@shs96c all tests are now passing, this is ready for review |
jin
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a situation where I need to disable
-use, but it was hardcoded intoJavadocJarMaker.java.I changed the way javadoc options work by making the
javadocoptsattribute completely replace the default options instead of adding to them.This is not completely backwards compatible. I thought about making it backwards compatible by adding some other flag like
override_default_javadocopts, but wasn't sure how people would feel about adding additional attributes.Open to changing this implementation or closing the PR if its not valuable enough.
Note: This is a copy of #1192 . I had to reopen the PR from a different Github fork because of new constraints in the previous one.