Add RJE_VERBOSE output when a BOM version is overridden by an explicit dependency#1172
Merged
shs96c merged 1 commit intoJun 19, 2024
Merged
Conversation
shs96c
approved these changes
Jun 19, 2024
| .filter(dep -> !artifactKeys.contains(getArtifactKey(dep.getArtifact()))) | ||
| .filter( | ||
| dep -> { | ||
| String artifactKey = getArtifactKey(dep.getArtifact()); |
Collaborator
There was a problem hiding this comment.
Nit: This could be done in a peek, but I guess here is fine too
Collaborator
Author
There was a problem hiding this comment.
I think you're right, the peek is better. Added in #1178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #1161 with verbose logging since I don't think overriding a version from dependencyManagement is uncommon in Maven.