pull: handle missing "registry" attr correctly #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to record what registry an image comes from to support shallow base images. When no registry is specified, pulling works, but the registry wasn't recorded. This leads to issues at deploy time, where the layers of the base image need to be streamed in if they are missing. Without a proper source, it's unlcear where to stream them from. This change ensures we always record a registry for any dowloaded image, even if the registry attr is left uninitialized. Fixes #65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to record what registry an image comes from to support shallow base images. When no registry is specified, pulling works, but the registry wasn't recorded. This leads to issues at deploy time, where the layers of the base image need to be streamed in if they are missing.
Without a proper source, it's unclear where to stream them from.
This change ensures we always record a registry for any downloaded image, even if the registry attr is left uninitialized.
Fixes #65