[wip] layer_from_pkg#523
Draft
peakschris wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188.
Adds
layer_from_pkgto//img:layer.bzl, which convertsrules_pkgpackaging manifests into OCI image layers. It acceptsPackageFilesInfo,PackageFilegroupInfo,PackageSymlinkInfo, andPackageDirsInfofromrules_pkg_providers— a lightweight BCR module whose only dependency isrules_license, sorules_pkgitself is not pulled in as a transitive dependency ofrules_img.Waiting on rules_pkg
rules_pkg 1.2.0 has not yet migrated to emit rules_pkg_providers providers — it still defines them inline. Until a new rules_pkg release adopts rules_pkg_providers, targets built with pkg_files / pkg_filegroup cannot be passed to layer_from_pkg directly.
For now, the e2e tests work around this with fake_pkg_* fixtures that mirror the rules_pkg API but emit providers from rules_pkg_providers directly. These fixtures can be replaced with real rules_pkg targets once that migration lands.