feat: image-optimize#517
Draft
Harshal96 wants to merge 1 commit into
Draft
Conversation
Collaborator
|
This looks very promising at first glance. I'll need some more time for an in-depth review. Thank you for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit
image_optimizerule for image-wide layer optimization.This lets users rewrite every available layer in an
image_manifestorimage_index, including eagerly materialized base-image layers, and enables whole-image eStargz output without changing the default shallow-pull behavior.Why
Issue #421 asks about applying eStargz at the image/base-image level. Instead of making
image_manifestorimage_indeximplicitly download and rewrite base layers, this adds a separate opt-in rule. That keeps shallow pulls cheap by default while giving users a clear path when they intentionally want all layers optimized.Changes
image_optimizeto@rules_img//img:image.bzlestargz = "enabled"for whole-image eStargz conversionrootfs.diff_idsdocs/image.mdTest Plan
bazel test @rules_img_tool//cmd/img:testbazel test //tests/img_toolchain:img_toolchain_testbazel test //util:buildifier.checkcd e2e/generic && bazel test //:optimize_tests