deploy rules: Use extra execution group to obtain "bazel run" tool #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
malt3
force-pushed
the
run_on_host_transition
branch
from
a017b20 to
fe6e042
Compare
malt3
changed the title
Any img tool can target any platform. The selection of different tools happens only via exec_compatible_with. Exec groups allow us to get multiple variants of the img tool: - The default exec group can be used at build time to build artifacts in actions - The host exec group provides an img tool that works with "bazel run"
…ent exec platforms
malt3
force-pushed
the
run_on_host_transition
branch
from
fe6e042 to
ebb3d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
image_push, image_load, and multi_deploy all need to symlink an
imgtool that can run on the host.Previously, we used a transition that would change the target platform of the img toolchain. This is effectively a no-op, since any img toolchain can target any platform.
Now, we use a little trick to add an extra exec platform (the host platform) at the beginning of the list of available exec platforms for the img tool.
This should result in the right img tool (executable on the host) being selected.