Skip to content

Add support for secondary landscape orientation on mobile devices #5

@bartread

Description

@bartread

Currently the game only works in primary landscape orientation, and you get the prompt to rotate your device if it's in secondary landscape orientation, which is confusing.

Reported by Alastair Smith in Slack:

Alastair Smith [5:56 PM] Star this file
uploaded and commented on an image: Ummmm...
1 Comment
Slightly broken on my iPhone 6S - that was taken in landscape orientation

Bart Read [5:57] Star this message
Oh, balls. Thanks. You mind if I borrow your 6S for a few minutes, please? Maybe Friday lunchtime?

Alastair Smith [5:58 PM] Star this message
It'll have to be next week (I'm OoO from lunch tomorrow), but sure.
Aha! It works if I rotate it to landscape in the ​_other_​ direction!

Bart Read [6:00 PM] Star this message
No worries, that'll be great. I need to put in a fix to get it to work at all on Android. The basic issue is that the event that fires when the orientation changes isn't entirely reliable (and doesn't work at all on Android). I ought to be able to more reliably detect by looking at screen dimensions.

Alastair Smith [6:00 PM] Star this message
Based on Netflix, YouTube, etc., I think I must hold my iPhone upside down in landscape mode.

Bart Read [6:01 PM] Star this message
Ah, yeah, that'll be it - it wants you to be in primary landscape mode. I ought to make it support secondary as well, but dealing with the orientation values is a real pain in the neck.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions