Fix memory issue in export command #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porting large volumes of translations from the DB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch translations in chunks to avoid early memory exhaustion when exporting large volumes of translations from the DB.
For reference, our
ltm_translationstable has over 300K records from the same group (1 excessively largeapp.phplang file serving dozens of locales) - chunking unblocksphp artisan translations:export app, though I do appreciate we do have an unusually large lang file.There are probably more memory efficient solutions than this that may or may not require a slightly smarter approach, but we can cross that bridge when it's necessary, this fix has been working well for us for some time now.