Adds ChromeOS detection, epiphany browser, and "Chromebook" device model#49
Open
eah13 wants to merge 6 commits intobarisaydinoglu:masterfrom
Open
Adds ChromeOS detection, epiphany browser, and "Chromebook" device model#49eah13 wants to merge 6 commits intobarisaydinoglu:masterfrom
eah13 wants to merge 6 commits intobarisaydinoglu:masterfrom
Conversation
src/detectizr.js
Outdated
| } else { | ||
| setVersion(browser, (test(/trident\/4\.0/) ? "8" : RegExp.$1)); | ||
| } | ||
| } else if (test(/iceweasel/)){ |
Owner
There was a problem hiding this comment.
One space required before opening brace for block expressions.
Author
|
Thanks- sorry about that. Forgot to run grunt test and grunt uglify. Was thinking they were wrapped into build latest commits add iceweasel and midori detection, to round out the common Raspberry Pi browsers. |
Owner
|
Could you please set version to 2.3.0, thanks :) |
Author
|
Done- thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if these are useful upstream but I needed to handle epiphany specifically and distinguish ChromeOS from other linux so thought I'd share.
Edit: come to think of it, the device.model addition probably conflates Chromebooks and Chromeboxes, so I could take that out.