[v2] fix icp meshconfig property name#831
Merged
waynz0r merged 1 commit intorelease-1.11from Feb 10, 2022
Merged
Conversation
waynz0r
force-pushed
the
fix-icp-patch-calc
branch
from
09df38b to
2744a2f
Compare
waynz0r
force-pushed
the
fix-icp-patch-calc
branch
from
2744a2f to
07f5a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes
meshConfigproperty name in icp proto.Why?
Even if the JSON tag was camelcase the snakecased name caused problems with strategic merge patch creation for the resource.