Skip to content

Fix: rotation on some android devices #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix: rotation on some android devices #398

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a1df493
Fix: rotation on some android devices
MrLibya Apr 3, 2024
1d4bfb3
Update ImageResizer.java
MrLibya Apr 4, 2024
4cf48af
Add: Handle mirror exif orientation
MrLibya May 1, 2024
f9012db
Update: limitations readme
MrLibya May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 35 additions & 19 deletions android/src/main/java/com/reactnativeimageresizer/ImageResizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,11 @@ private static Bitmap resizeImage(Bitmap image, int newWidth, int newHeight,
/**
* Rotate the specified bitmap with the given angle, in degrees.
*/
public static Bitmap rotateImage(Bitmap source, float angle)
public static Bitmap rotateImage(Bitmap source, Matrix matrix, float angle)
{
Bitmap retVal;

Matrix matrix = new Matrix();
matrix.postRotate(angle);

try {
retVal = Bitmap.createBitmap(source, 0, 0, source.getWidth(), source.getHeight(), matrix, true);
} catch (OutOfMemoryError e) {
Expand Down Expand Up @@ -316,39 +315,57 @@ public static boolean copyExif(Context context, Uri imageUri, String dstPath){
/**
* Get orientation by reading Image metadata
*/
public static int getOrientation(Context context, Uri uri) {
public static Matrix getOrientationMatrix(Context context, Uri uri) {
try {
// ExifInterface(InputStream) only exists since Android N (r24)
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
InputStream input = context.getContentResolver().openInputStream(uri);
ExifInterface ei = new ExifInterface(input);
return getOrientation(ei);
return getOrientationMatrix(ei);
}
File file = getFileFromUri(context, uri);
if (file.exists()) {
ExifInterface ei = new ExifInterface(file.getAbsolutePath());
return getOrientation(ei);
return getOrientationMatrix(ei);
}
} catch (Exception ignored) { }

return 0;
return new Matrix();
}

/**
* Convert metadata to degrees
*/
public static int getOrientation(ExifInterface exif) {
int orientation = exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, ExifInterface.ORIENTATION_NORMAL);
public static Matrix getOrientationMatrix(ExifInterface exif) {
Matrix matrix = new Matrix();
int orientation = exif.getAttributeInt(ExifInterface.TAG_ORIENTATION, ExifInterface.ORIENTATION_UNDEFINED);
switch (orientation) {
case ExifInterface.ORIENTATION_FLIP_HORIZONTAL:
matrix.setScale(-1, 1);
break;
case ExifInterface.ORIENTATION_TRANSPOSE:
matrix.setRotate(90);
matrix.postScale(-1, 1);
break;
case ExifInterface.ORIENTATION_ROTATE_90:
return 90;
matrix.setRotate(90);
break;
case ExifInterface.ORIENTATION_FLIP_VERTICAL:
matrix.setRotate(180);
matrix.postScale(-1, 1);
break;
case ExifInterface.ORIENTATION_ROTATE_180:
return 180;
matrix.setRotate(180);
break;
case ExifInterface.ORIENTATION_TRANSVERSE:
matrix.setRotate(270);
matrix.postScale(-1, 1);
break;
case ExifInterface.ORIENTATION_ROTATE_270:
return 270;
default:
return 0;
}
matrix.setRotate(270);
break;
}
return matrix;
}

/**
Expand Down Expand Up @@ -549,15 +566,14 @@ public static Bitmap createResizedImage(Context context, Uri imageUri, int newWi
// get wrong dimensions if we want the new dimensions to be after rotation.
// NOTE: This will "fix" the image using it's exif info if it is rotated as well.
Bitmap rotatedImage = sourceImage;
int orientation = getOrientation(context, imageUri);
rotation = orientation + rotation;
rotatedImage = ImageResizer.rotateImage(sourceImage, rotation);
Matrix matrix = getOrientationMatrix(context, imageUri);
rotatedImage = ImageResizer.rotateImage(sourceImage, matrix, rotation);

if(rotatedImage == null){
throw new IOException("Unable to rotate image. Most likely due to not enough memory.");
}

if (rotatedImage != rotatedImage) {
if (rotatedImage != sourceImage) {
sourceImage.recycle();
}

Expand Down