fix typing to make outputPath actually accept null #395

1mike12 · 2024-02-13T00:53:02Z

the docs say

If null, resized image will be stored in cache folder.

the native code seems to allow for null values, but js side types don't match

change signature to match the docs / java/ objc code that say null is allowed to use the cache directory

change types

gh-clement-taboulot · 2024-02-28T10:00:25Z

@1mike12 Thx for the PR.
We will find someone next week at BAM to review it.

1mike12 added 2 commits February 12, 2024 18:49

Update index.tsx

fb69114

change signature to match the docs / java/ objc code that say null is allowed to use the cache directory

Update NativeImageResizer.ts

13ab88e

change types

gh-clement-taboulot merged commit 47c7f86 into bamlab:master Apr 24, 2024

Provide feedback