Skip to content

Conversation

@Psiiirus
Copy link
Contributor

new up to date PR for #160

I'm also extended the /example project to be useable for development and unf. i found out that this still blocks the UI. Any clue why?

new up to date PR for #160
@PierreCapo
Copy link
Contributor

@Psiiirus Can you confirm we can close #160 and use that PR instead ?

@Psiiirus
Copy link
Contributor Author

Yeah I think so.

@PierreCapo PierreCapo merged commit 344b466 into bamlab:master Jan 3, 2020
@cristianoccazinsp
Copy link
Contributor

Can you guys confirm/tested that the following lines are no longer needed?

if ([path hasPrefix:@"data:"] || [path hasPrefix:@"file:"]) {
                NSURL *imageUrl = [[NSURL alloc] initWithString:path];
                image = [UIImage imageWithData:[NSData dataWithContentsOfURL:imageUrl]];
            } else {
                image = [[UIImage alloc] initWithContentsOfFile:path];
            }

Do files and data: schemas load fine with loadImageWithURLRequest ?

@Psiiirus
Copy link
Contributor Author

Psiiirus commented Jan 8, 2020

@cristianoccazinsp if i remember correct did tests with base64 and file urls which where working fine not but i cant remember if i tested all kinds of asset-url-types, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants