Async Task for Resize #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move resize operation to a parallel async task in order to avoid blocking React's bridge.
|
Forgot to mention, this is Android only change. |
|
We have been using this fork in our beta app https://github.com/digidem/mapeo-mobile and it has been working well without problems. I support merging this @Minishlink |
Looks like this was left from some debug code...
|
Any updates? Could really have this merged |
|
@cristianoccazinsp Sorry for the delay. Gonna try to review this asap. |
|
I've added a new commit that adds width and height (in pixels) to the returned data. iOS was quite straight forward, while Android required a few organization updates (return bitmap instead of file, and handle file later) |
…the picture has exif rotation. This would also match iOS behavour.
|
Thanks a lot for the pr and all the work done @cristianoccazinsp . This is available on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move resize operation to a parallel async task in order to avoid blocking React's bridge.