Skip to content

🐛 fix(radio): can not be unselected #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirsch88 merged 2 commits into from
May 21, 2025
Merged

🐛 fix(radio): can not be unselected #1699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a2ee5
fix(radio): can not be unselected
hirsch88 May 21, 2025
7c4f967
chore: fix e2e test
hirsch88 May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-cameras-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@baloise/ds-core': patch
---

**radio**: radio can not be unselected
11 changes: 2 additions & 9 deletions packages/core/src/components/bal-radio/bal-radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,14 +311,6 @@ export class Radio implements ComponentInterface, BalElementStateInfo, Loggable,
this.checked = newChecked
}
}

// if (this.radioButton) {
// this.buttonTabindex = -1

// if (this.radioButton.setChecked) {
// this.radioButton.setChecked(this.checked)
// }
// }
}

/**
Expand Down Expand Up @@ -384,7 +376,8 @@ export class Radio implements ComponentInterface, BalElementStateInfo, Loggable,
ev.preventDefault()

this.setFocus()
this.setChecked(!this.checked)
this.checked = true
this.setChecked(this.checked)
}

private onClick = (ev: MouseEvent) => {
Expand Down
Loading