update containers base images #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Member
vipulgupta2048
left a comment
vipulgupta2048
left a comment
There was a problem hiding this comment.
THanks for your contribution @ycardaillac
| @@ -1,4 +1,4 @@ | |||
| FROM balenalib/%%BALENA_MACHINE_NAME%%-node:10 | |||
| FROM node:10 | |||
Member
There was a problem hiding this comment.
Can we also update the node version to whatever is LTS
Change-type: patch Signed-off-by: Yann CARDAILLAC <[email protected]>
ycardaillac
force-pushed
the
update-docker-images
branch
from
ed4bf9c to
827d11a
Compare
vipulgupta2048
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly an update to Docker images.
Note that for systemd/printer/Dockerfile.template the file is initially empty and is intended to be copied from the master class. So this update necessitate an update on the master class side too.