feat: improve forgeStageTwoQuery to allow select/omit for singular model populate

[DominusKelvin]

Resolves balderdashy/sails#4667

I also account for the normal behaviour of Waterline projections not allowing both select and omit

Now this sort of subcriteria will be treated as valid subcriteria for populating associations

 const tickets = await Ticket.find({
      where: { event: event.id, status: { '!=': 'cancelled' } },
      sort: 'ticketHolderEmail DESC',
      select: ['ticketHolderEmail', 'status', 'publicId']
    })
      .populate('ticketType', { select: ['name'] })
      .populate('order')

[luislobo]

Good improvement! It would be good to have unit tests

[DominusKelvin]

Yes @luislobo

[DominusKelvin]

Hey @luislobo. I just added three test cases for this.

[luislobo]

@DominusKelvin great! I added some comments

[luislobo]

I've added more comments, there is actually an issue on "select"

[DominusKelvin]

I've added more comments, there is actually an issue on "select"

Hey @luislobo what's the issue you saw?

[luislobo]

your changes do not do what the issue is asking: omit does not omit and select does not select, because the current waterline implementation does not process select and omit on populates, it only does it on the main model's select and omit. Your change just lets those fields to be validated in the configruation. If you add the tests that I mentioned on the code, you will see what I mean.

[luislobo]

BTW, I do have an implementation for this version of Waterline that implements this, I could create a separate PR that does it. But since I'm not using this version of Waterline yet, I didn't create a PR.

[DominusKelvin]

BTW, I do have an implementation for this version of Waterline that implements this, I could create a separate PR that does it. But since I'm not using this version of Waterline yet, I didn't create a PR.

Oh really I did test it out on my current Sails and Waterline versions

I'll test it out again to confirm

[luislobo]

Here's the PR that takes care of the select/omit on propulated entities #1628