[patch] Allow populates to use select/omit for singular associations#1615
Open
danielsharvey wants to merge 1 commit intobalderdashy:masterfrom
Open
[patch] Allow populates to use select/omit for singular associations#1615danielsharvey wants to merge 1 commit intobalderdashy:masterfrom
danielsharvey wants to merge 1 commit intobalderdashy:masterfrom
Conversation
Currently the populates clause is allowed for plural ("collection")
associations but disallowed for singular ("model") associations.
This patch allows only a select or an omit for singular associations.
Author
|
I have reviewed the code, run the tests and tested within my own use cases. Are there other tests that should be run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the populates clause is allowed for plural ("collection")
associations but disallowed for singular ("model") associations.
This patch allows only a select or an omit for singular associations.