Fix for selecting specific fields in population for one-to-one relationship#1613
Open
TahaBoulehmi wants to merge 2 commits intobalderdashy:masterfrom
Open
Fix for selecting specific fields in population for one-to-one relationship#1613TahaBoulehmi wants to merge 2 commits intobalderdashy:masterfrom
TahaBoulehmi wants to merge 2 commits intobalderdashy:masterfrom
Conversation
…onship If there is a population for a one-to-one relationship, we should accept only "select" and "omit" attributes.
Merged
|
Any progress on this guys? This is one of long awaited fix from sails developers. Thanks! |
Contributor
|
I would love to have this merged as well.. I use this feature frequently ! Thanks @TahaBoulehmi for the fix |
|
What is holding this back? Needed this today, using your fix, thanks @TahaBoulehmi |
|
Please merge this! Vital stuff that's been waiting for a long time. We also would make heavy use of populate select for one-to-one relationships. |
|
can wait till this is fully reviewed, great fix. Already tested the change and works like a charm. Please hurry and merge |
|
Is it possible to get this reviewed soon? Need it urgently |
|
is there any update on this? i'm refactoring a big code base that uses a lot of native sql queries, and that would be very handy on a lot of cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for selecting specific fields in population for one-to-one relationship
If there is a population for a one-to-one relationship, we should accept only "select" and "omit" attributes.