[proposal] Update transformer-builder#1587
Open
lelkadi wants to merge 2 commits intobalderdashy:masterfrom
Open
[proposal] Update transformer-builder#1587lelkadi wants to merge 2 commits intobalderdashy:masterfrom
lelkadi wants to merge 2 commits intobalderdashy:masterfrom
Conversation
In the unserialize(), only transform pRecord's columns that match model's attributes. Or in other words, skip any fields available in the pRecord that don't match any attribute of the Model.
|
Hi @lelkadi! It looks like your pull request title doesn’t quite conform to our guidelines. Please edit the title so that it starts with [proposal], [patch], [fixes #], or [implements #]. Once you've fixed it, post a comment below (e.g. "ok, fixed!") and we'll take a look! |
lelkadi
changed the title
Author
|
ok, fixed! |
Author
|
I think this proposed change is essential for an ORM, as it allows more control on the data on the Model level. |
Changing let keyword to var, in transformer's unserialize(), for backward compatibility with old JS versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the unserialize(), only transform pRecord's columns that match model's attributes.
Or in other words, skip any fields available in the pRecord that don't match any attribute of the Model.