[proposal] Internal mutateArgs usage in core#1529
Open
mikermcneil wants to merge 14 commits intomasterfrom
Open
[proposal] Internal mutateArgs usage in core#1529mikermcneil wants to merge 14 commits intomasterfrom
mutateArgs usage in core#1529mikermcneil wants to merge 14 commits intomasterfrom
Conversation
…ing from .destroy(). (Still needs some love.)
…p the Archived model (which doesn't exist yet)
…me additional notes for future reference.
… the forging from the find query) so that the destroy() query works. Note: At this point, you can take this and use .archive() at the app-level in your own project, provided you hook up your own Archive model. But in subsequent commits, I'll write some code that injects this model automatically, unless configured otherwise.
… it's actually faster, otherwise no reason to include any of this extra complexity.
mikermcneil
changed the title
mutateArgs could be used to hypothetically make queries faster by avoiding unnecessary object cloning internally. The next step is to benchmark this-- without benchmarks proving this is actually faster, it would be a mistake to merge this into core.mutateArgs usage in core
Member
Author
|
This demonstrates how |
Member
Author
|
@sgress454 I reckon you're talking about .archive() right? (I think the PRs might have crossed streams) |
Member
|
@mikermcneil I was commenting in the source, I guess the specific commit must be part of this PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more background, see https://trello.com/c/QapDT6XY/87-could-not-fetch-session-socket-has-no-cookie-in-its-handshake-edit-nevermind-see-updated-description