[patch] Fix issue where attribute is required and is a model attribute#1467
Merged
sgress454 merged 1 commit intobalderdashy:masterfrom Sep 21, 2017
Merged
Conversation
|
Hi @luislobo! It looks like your pull request title doesn’t quite conform to our guidelines. Please edit the title so that it starts with [proposal], [patch], [fixes #], or [implements #]. Once you've fixed it, post a comment below (e.g. "ok, fixed!") and we'll take a look! |
luislobo
changed the title
Contributor
Author
|
ok, sailor, all fixed! |
Member
|
@luislobo Looks like @mikermcneil patched this awhile ago, but appreciate the contribution and Github says I can merge it anyway so...MERGED! |
Member
|
@luislobo 🍾 ⛵️ 🏳️🌈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where attribute is required and is a model attribute. It was throwing an error about
Error: Consistency violation:modelIdentitymust be a non-empty string. Instead got: undefinedbecause collection was not existing, as it is a required model attribute.