Pass valuesObject.criteria to beforeCallbacks#1120
Closed
mmiller42 wants to merge 2 commits intobalderdashy:masterfrom
Closed
Pass valuesObject.criteria to beforeCallbacks#1120mmiller42 wants to merge 2 commits intobalderdashy:masterfrom
mmiller42 wants to merge 2 commits intobalderdashy:masterfrom
Conversation
Contributor
|
#1004 is in the 0.11 milestone, and we expect this to be a breaking change. Want to make a PR with the breaking change to the |
Author
|
Sure. Since you are expecting a breaking change, should I rearrange the arguments to put |
Author
|
Opened PR #1122 with test coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass criteria to the beforeUpdate callbacks. Passes criteria as the last argument, which does not follow the Node.js convention of putting the callback last, but it would be a non-breaking change to existing implementations that expect arguments as they were.
Serves as a solution to issue #1004.