Add support for array-ish and clause#68
Add support for array-ish and clause#68anotherpit wants to merge 2 commits intobalderdashy:masterfrom
and clause#68Conversation
Merge from main repo
|
Moreover, according to its tests the fellow waterline-criteria library already supports this syntax for |
|
Any thoughts on this PR, guys? |
|
@anotherpit I dig it, sorry haven't had time to get into it. We also need some tests in waterline-adapter-tests to show it works in adapters not using wl-sequel such as mongo, etc. |
|
@anotherpit also this is supported in the updated criteria/query syntax I'm working on. |
|
This would be nice to see get merged. Though, we get around this issue, with the mongo adapter, by using |
|
Any status on this.. ? And btw thanks @jgeurts, you made my day with
|
|
@anotherpit Oh my god! This is beautifully done! This is exactly what I was looking for for over 2 months! |
|
Yes! We needed this for some of our queries as well. I was about to post a PR with this fix, but @anotherpit did a great job and included tests! it seems I'd love to see this merged soon. |
...which also gives you a support for nested and mixed
andandorclauses. Like these:Effectively closes https://github.com/balderdashy/waterline/issues/828