Conversation
There was a problem hiding this comment.
Looks like this comment is out of date now
There was a problem hiding this comment.
Yeah, in the former case at least.
|
Looks good to me! Can we do better with just a little more effort? I think we can use the new strategy whenever there's no limit/skip/sort. Basically, the new case you added should be able to withstand a where clause. |
|
What you mean to do better with less effort? These changes have done better and minimal changes. |
|
Didn't mean to make it sound like this change was unappreciated, so I hope it didn't come off that way! We're happy to have it. I just meant that we may be able to use the optimized query (the one you added) in more cases by putting in a little more time to write code that covers those cases. Looking into it, that might be a more complicated change than I had anticipated. This looks good. @particlebanana mind peekin'? |
|
Bump! |
|
Can we get a test added for this? |
5 participants
If no conditions LIMIT and OFFSET, your request will be like this:
SELECT COUNT(*) as count FROM (SELECT * FROM "tablename" ) AS "tablename".