Ensure nested updates actually updates the child records#51
Open
dmarcelino wants to merge 2 commits intomasterfrom
Open
Ensure nested updates actually updates the child records#51dmarcelino wants to merge 2 commits intomasterfrom
dmarcelino wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Investigating balderdashy/waterline#964 made me realise that nested updates in the form of
User.update({id: 1 }, { posts: [ { id: 1, title: 'Test post - updated' }] })works for 1:1 and 1:m associations but breaks for m:n associations. I'm unsure if this is a waterline core issue or something that needs to be dealt in the adapters or both. But it's something we should look into in order to keep the API consistent between associations types: balderdashy/waterline#965.This PR ensures nested updates actually updates the child values and this currently breaks on all official adapters (example). The fix for this issue will have to pass this version of the tests.
Tasks:
⛔ Do not merge until we figure a solution for this! ⛔